tests: don't patch private ops class #519
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 66.25% 65.44% -0.82%
==========================================
Files 17 18 +1
Lines 3180 4092 +912
Branches 424 588 +164
==========================================
+ Hits 2107 2678 +571
- Misses 935 1205 +270
- Partials 138 209 +71 ☔ View full report in Codecov by Sentry. |
dragomirp
requested review from
a team,
paulomach,
taurus-forever,
shayancanonical and
carlcsaposs-canonical
and removed request for
a team
There was a problem hiding this comment.
Dear @tonyandrewmeyer , thank you for the contribution!
Good to hear it is no longer necessary!!!
P.S. should we share this information locally OR you are going to patch all those repos:
14:23:00 ✔ taurus:~/canonical/git/$ rg patch_network_get . | awk -F'/' '{print $2}' | uniq
mysql-operator
pgbouncer-operator
postgresql-operator
postgresql-k8s-operator
s3-integrator
mongodb-operator
mongodb-k8s-operator
opensearch-operator
I've opened PRs for prometheus-k8s-operator, grafana-k8s-operator, postgresql-operator, postgresql-k8s-operator/pull/692, and (obviously) mysql-operator. My hope was to let the others (I have a list of 12 that I could find) know and let teams do the fix themselves, if possible. |
Issue
The tests currently patch a private ops class. The private names have no compatibility guarantee, and this will stop working in an upcoming ops release.
Solution
Remove the patching, which is not required in modern ops. Also update the expect default IP (from Cloudflare's DNS server, which we shouldn't be using anyway).